refactor: make index building reusable#401
Open
dkharms wants to merge 6 commits into
Open
Conversation
Contributor
|
❌ PR Title Validation Failed |
1 similar comment
Contributor
|
❌ PR Title Validation Failed |
dkharms
force-pushed
the
336-sealing-split
branch
from
f522008 to
3349041
Compare
dkharms
force-pushed
the
336-blockbuilder
branch
from
4dbb2de to
b157354
Compare
dkharms
force-pushed
the
336-sealing-split
branch
from
4acc3e9 to
a9e9ec1
Compare
6 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
==========================================
- Coverage 70.65% 70.63% -0.02%
==========================================
Files 219 220 +1
Lines 16967 16964 -3
==========================================
- Hits 11988 11983 -5
- Misses 4084 4085 +1
- Partials 895 896 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Another pull request in series of #336
Now, processing of sealing, index building and blocks building are tightly coupled, however we could reuse blocks and index building for compaction as well.
This PR separates these processes into different packages.
If you have used LLM/AI assistance please provide model name and full prompt: